Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement custom converter types #256

Merged
merged 9 commits into from
Oct 18, 2021
Merged

Implement custom converter types #256

merged 9 commits into from
Oct 18, 2021

Conversation

Dorukyum
Copy link
Member

@Dorukyum Dorukyum commented Oct 7, 2021 •
edited

Summary

This adds custom converters to application commands.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, ...)

CodeWithSwastik
CodeWithSwastik reviewed Oct 8, 2021
View reviewed changes
discord/commands/commands.py Outdated Show resolved Hide resolved
discord/commands/commands.py Outdated Show resolved Hide resolved
@CodeWithSwastik CodeWithSwastik added the status: in progress Work in Progess label Oct 8, 2021
@Dorukyum
Copy link
Member Author

Dorukyum commented Oct 8, 2021

The suggested changes have been done.

@Dorukyum Dorukyum marked this pull request as ready for review October 8, 2021 14:40
Lulalaby
Lulalaby approved these changes Oct 13, 2021
View reviewed changes
Copy link
Member

@Lulalaby Lulalaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dorukyum Dorukyum merged commit c168781 into Pycord-Development:restructure Oct 18, 2021
@Dorukyum Dorukyum added this to Done in v2.0 Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lulalaby Lulalaby Lulalaby approved these changes

@CodeWithSwastik CodeWithSwastik CodeWithSwastik approved these changes

@Middledot Middledot Middledot left review comments

@BobDotCom BobDotCom BobDotCom approved these changes

Assignees
No one assigned
Labels
status: in progress Work in Progess
Projects
No open projects
v2.0
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Dorukyum @Lulalaby @CodeWithSwastik @BobDotCom @Middledot