Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move commands.Bot listener methods to discord.Bot #305

Merged
merged 1 commit into from
Oct 25, 2021
Merged

Move commands.Bot listener methods to discord.Bot #305

merged 1 commit into from
Oct 25, 2021

Conversation

ToxicKidz
Copy link
Contributor

Fixes #290

Summary

This PR moves the listener methods from commands.Bot to discord.Bot to allow listeners in discord.Cog.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, ...)

@BobDotCom
Copy link
Member

Docs will need to be updated for this, won't they? I think this might cause the docs to fail.

@ToxicKidz
fix: Move commands.Bot listener methods to discord.Bot
c0ab421 
This allows listeners to work in discord.Cog
@BobDotCom BobDotCom merged commit 25b1631 into Pycord-Development:master Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dorukyum Dorukyum Dorukyum approved these changes

@BobDotCom BobDotCom BobDotCom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@commands.Cog.listener() raises errors
3 participants
@ToxicKidz @BobDotCom @Dorukyum