Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate file checks #333

Merged
merged 1 commit into from
Oct 29, 2021
Merged

Remove duplicate file checks #333

merged 1 commit into from
Oct 29, 2021

Conversation

Dorukyum
Copy link
Member

Summary

Fixes #311 by removing duplicate code.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, ...)

zeffo
zeffo approved these changes Oct 26, 2021
View reviewed changes
Copy link
Contributor

@zeffo zeffo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ToxicKidz
ToxicKidz approved these changes Oct 26, 2021
View reviewed changes
Copy link
Contributor

@ToxicKidz ToxicKidz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

Lulalaby
Lulalaby approved these changes Oct 27, 2021
View reviewed changes
Copy link
Member

@Lulalaby Lulalaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dorukyum Dorukyum merged commit 4fb38da into Pycord-Development:master Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lulalaby Lulalaby Lulalaby approved these changes

@zeffo zeffo zeffo approved these changes

@CodeWithSwastik CodeWithSwastik CodeWithSwastik approved these changes

@BobDotCom BobDotCom BobDotCom approved these changes

@ToxicKidz ToxicKidz ToxicKidz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect InvalidArgument when reponding with files
6 participants
@Dorukyum @Lulalaby @zeffo @CodeWithSwastik @BobDotCom @ToxicKidz