Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Support for thread_id on Webhook Messages #335

Merged
merged 3 commits into from
Oct 28, 2021
Merged

Added Support for thread_id on Webhook Messages #335

merged 3 commits into from
Oct 28, 2021

Conversation

Makiyu-py
Copy link
Contributor

Summary

I basically implemented #321 / discord/discord-api-docs#3995

I almost didn't implement it on fetch_message because it looked silly but I added it anyway last minute.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, ...)

Lulalaby
Lulalaby requested changes Oct 28, 2021
View reviewed changes
Copy link
Member

@Lulalaby Lulalaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code: ✔️ LGTM
Docs: ❌

discord/webhook/async_.py Outdated Show resolved Hide resolved
discord/webhook/async_.py Outdated Show resolved Hide resolved
discord/webhook/async_.py Outdated Show resolved Hide resolved
discord/webhook/sync.py Outdated Show resolved Hide resolved
discord/webhook/sync.py Outdated Show resolved Hide resolved
discord/webhook/sync.py Outdated Show resolved Hide resolved
discord/webhook/sync.py Outdated Show resolved Hide resolved
@Lulalaby
Copy link
Member

Closes #321

@Makiyu-py @Lulalaby
Apply Lalasuggestions from code review
c9f66c4 
Co-authored-by: Lala Sabathil <aiko@aitsys.dev>
Lulalaby
Lulalaby previously approved these changes Oct 28, 2021
View reviewed changes
Copy link
Member

@Lulalaby Lulalaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeWithSwastik @BobDotCom

Dorukyum
Dorukyum reviewed Oct 28, 2021
View reviewed changes
discord/webhook/async_.py Outdated Show resolved Hide resolved
@Makiyu-py @Dorukyum
versionadded mistake oops
1d09bf2 
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
@Dorukyum Dorukyum merged commit 9496c72 into Pycord-Development:master Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dorukyum Dorukyum Dorukyum approved these changes

@Middledot Middledot Middledot approved these changes

@Lulalaby Lulalaby Lulalaby left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Makiyu-py @Lulalaby @Dorukyum @Middledot