Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cmd returning None in register_commands due to API change/bug #349

Merged
merged 2 commits into from
Oct 30, 2021

Conversation

TheGamerX20
Copy link
Contributor

Summary

Discord states that a Context Menu command's description will be returned as an Empty string when fetched here:
https://discord.com/developers/docs/interactions/application-commands#user-commands

But at the moment, they seem to be returning null, and since the commands are registered with an empty string in pycord, "cmd = get" will not find the command and return None, and this causes an error when getting cmd.permissions.

This pull request temporarily fixes it by changing None into an empty string in register_commands before get.
Another way to fix this would be to set ContextMenuCommand's description to None on init.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, ...)

Copy link
Contributor

@krittick krittick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified this works for me on my local build.

@BobDotCom BobDotCom merged commit 952b5ec into Pycord-Development:master Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants