Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AutocompleteContext for autocomplete callbacks #361

Merged
merged 10 commits into from
Nov 3, 2021
Merged

Add AutocompleteContext for autocomplete callbacks #361

merged 10 commits into from
Nov 3, 2021

Conversation

zeffo
Copy link
Contributor

@zeffo zeffo commented Oct 31, 2021

Summary

This PR adds AutocompleteContext. This context is passed to Option.autocomplete.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, ...)

izxxr
izxxr suggested changes Oct 31, 2021
View reviewed changes
Copy link
Contributor

@izxxr izxxr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs fixes, Ignore the syntax highlighting in suggestions. they seem broken or i don't know how to use them.

discord/commands/context.py Outdated Show resolved Hide resolved
discord/commands/context.py Outdated Show resolved Hide resolved
Lulalaby
Lulalaby requested changes Oct 31, 2021
View reviewed changes
discord/commands/context.py Outdated Show resolved Hide resolved
Lulalaby and others added 2 commits October 31, 2021 14:37
@Lulalaby @izxxr
Update discord/commands/context.py
27a880b 
Co-authored-by: Izhar Ahmad <54180221+nerdguyahmad@users.noreply.github.com>
@Lulalaby
Update discord/commands/context.py
a9aa0fe
@Lulalaby Lulalaby added feature Implements a feature priority: high High Priority status: in progress Work in Progess labels Oct 31, 2021
@Lulalaby Lulalaby added this to In progress in v2.0 via automation Oct 31, 2021
@zeffo zeffo marked this pull request as ready for review October 31, 2021 15:46
@zeffo
Copy link
Contributor Author

zeffo commented Oct 31, 2021

This should be slotted, no?

@izxxr
Copy link
Contributor

izxxr commented Oct 31, 2021

This should be slotted, no?

Yes, it should be.

@zeffo
Copy link
Contributor Author

zeffo commented Oct 31, 2021

fuck i messed something up

@zeffo
Copy link
Contributor Author

zeffo commented Oct 31, 2021

can someone do black git magic and fix my shit, ty

@izxxr
Copy link
Contributor

izxxr commented Oct 31, 2021

Everything's fine.

@zeffo
Copy link
Contributor Author

zeffo commented Oct 31, 2021

image
Are these supposed to be here

@Lulalaby
Copy link
Member

Lulalaby commented Nov 1, 2021

image
Are these supposed to be here

Yes because I committed it

izxxr
izxxr previously approved these changes Nov 1, 2021
View reviewed changes
Lulalaby
Lulalaby previously approved these changes Nov 1, 2021
View reviewed changes
Copy link
Member

@Lulalaby Lulalaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lulalaby @BobDotCom
Update discord/commands/context.py
3f28ebb 
Co-authored-by: BobDotCom <71356958+BobDotCom@users.noreply.github.com>
@Lulalaby Lulalaby dismissed stale reviews from izxxr and themself via 3f28ebb November 2, 2021 14:53
@BobDotCom BobDotCom mentioned this pull request Nov 2, 2021
Closed
6 tasks
BobDotCom
BobDotCom requested changes Nov 2, 2021
View reviewed changes
Copy link
Member

@BobDotCom BobDotCom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update utils.basic_autocomplete for this functionality

@zeffo zeffo requested a review from BobDotCom November 3, 2021 05:49
@CodeWithSwastik CodeWithSwastik merged commit a0e6612 into Pycord-Development:autocomplete Nov 3, 2021
v2.0 automation moved this from In progress to Done Nov 3, 2021
@CodeWithSwastik CodeWithSwastik mentioned this pull request Nov 3, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodeWithSwastik CodeWithSwastik CodeWithSwastik approved these changes

@izxxr izxxr Awaiting requested review from izxxr

@Lulalaby Lulalaby Awaiting requested review from Lulalaby

@BobDotCom BobDotCom Awaiting requested review from BobDotCom

Assignees

@Lulalaby Lulalaby

@zeffo zeffo

@izxxr izxxr

Labels
feature Implements a feature priority: high High Priority status: in progress Work in Progess
Projects
No open projects
v2.0
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@zeffo @izxxr @Lulalaby @CodeWithSwastik @BobDotCom