Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples to the This PR is not a code change (e.g. documentation, README, typehinting, ...) #386

Merged
merged 1 commit into from
Nov 3, 2021

Conversation

Sengolda
Copy link
Contributor

@Sengolda Sengolda commented Nov 3, 2021

Summary

This PR adds examples to the This PR is not a code change (e.g. documentation, README, typehinting, ...)

before:

This PR is not a code change (e.g. documentation, README, typehinting, ...)

after:

This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, ...)

@Dorukyum
Copy link
Member

Dorukyum commented Nov 3, 2021

Examples would count as documentation in my opinion. It's okay if others agree tho.

@Lulalaby Lulalaby added priority: low Low Priority status: awaiting review Awaiting review from a maintainer labels Nov 3, 2021
@BobDotCom BobDotCom merged commit cf07dae into Pycord-Development:master Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low Low Priority status: awaiting review Awaiting review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants