Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Channel Banner Feature Flag #421

Merged
merged 2 commits into from
Nov 9, 2021
Merged

Add Channel Banner Feature Flag #421

merged 2 commits into from
Nov 9, 2021

Conversation

Lulalaby
Copy link
Member

@Lulalaby Lulalaby commented Nov 8, 2021

No description provided.

@Lulalaby Lulalaby added documentation Improvements or additions to documentation priority: low Low Priority labels Nov 8, 2021
@Lulalaby Lulalaby self-assigned this Nov 8, 2021
@Lulalaby Lulalaby mentioned this pull request Nov 8, 2021
Closed
3 tasks
@Dorukyum
Copy link
Member

Dorukyum commented Nov 9, 2021

Shouldn't this be added as an attribute too?

@FrostByte266
Copy link
Contributor

Shouldn't this be added as an attribute too?

Actually, I completely missed this. It does need to be added under the GuildFeatures type in discord/types/guild.py

FrostByte266
FrostByte266 requested changes Nov 9, 2021
View reviewed changes
Copy link
Contributor

@FrostByte266 FrostByte266 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHANNEL_BANNER needs to be added to the GuildFeature type in discord/types/guild.py

Dorukyum
Dorukyum requested changes Nov 9, 2021
View reviewed changes
discord/guild.py Show resolved Hide resolved
@Lulalaby
Copy link
Member Author

Lulalaby commented Nov 9, 2021

CHANNEL_BANNER needs to be added to the GuildFeature type in discord/types/guild.py

That's not in the scope of the pr.
Instead it should be added in #423

@Lulalaby Lulalaby merged commit 644054f into master Nov 9, 2021
@Lulalaby Lulalaby deleted the guild/channelbanner branch November 9, 2021 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrostByte266 FrostByte266 FrostByte266 approved these changes

@Dorukyum Dorukyum Dorukyum approved these changes

@Middledot Middledot Awaiting requested review from Middledot

Assignees

@Lulalaby Lulalaby

Labels
documentation Improvements or additions to documentation priority: low Low Priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Lulalaby @Dorukyum @FrostByte266