Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesigning slash command groups #462

Merged
merged 22 commits into from
Dec 15, 2021
Merged

Redesigning slash command groups #462

merged 22 commits into from
Dec 15, 2021

Conversation

Dorukyum
Copy link
Member

@Dorukyum Dorukyum commented Nov 15, 2021 •
edited

Summary

This merges groups. Closes #372.

@CodeWithSwastik CodeWithSwastik added priority: high High Priority status: in progress Work in Progess labels Nov 15, 2021
@BobDotCom BobDotCom changed the title Redesing slash command groups Redesigning slash command groups Nov 15, 2021
@BobDotCom BobDotCom added this to In progress in v2.0 Nov 15, 2021
@BobDotCom BobDotCom added this to the v2.0 milestone Nov 15, 2021
@Dorukyum Dorukyum self-assigned this Nov 17, 2021
@Dorukyum Dorukyum added the feature Implements a feature label Nov 17, 2021
@Dorukyum Dorukyum marked this pull request as ready for review November 21, 2021 06:48
BobDotCom
BobDotCom previously requested changes Nov 21, 2021
View reviewed changes
Copy link
Member

@BobDotCom BobDotCom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will finish more changes once I'm on my computer.

discord/bot.py Outdated Show resolved Hide resolved
BobDotCom
BobDotCom reviewed Nov 22, 2021
View reviewed changes
discord/bot.py Outdated Show resolved Hide resolved
@BobDotCom BobDotCom mentioned this pull request Nov 29, 2021
Merged
VincentRPS
VincentRPS previously approved these changes Nov 30, 2021
View reviewed changes
HexF and others added 6 commits December 5, 2021 02:23
@HexF
Add support for slash-command groups on cogs
6170c6b
@HexF
Add _set_cog to Command
a84b1af
@HexF @Dorukyum
Update discord/commands/commands.py
452f6b9 
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
@HexF @Dorukyum
Update discord/commands/commands.py
fa7cf47 
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
@HexF @Dorukyum
Update discord/cog.py
f0a4010 
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
@HexF
Add check for sub-commands to ApplicationCommandMixin.add_application…
1427e10 
…_command
@Dorukyum Dorukyum added status: awaiting review Awaiting review from a maintainer and removed status: in progress Work in Progess labels Dec 5, 2021
@Dorukyum
Copy link
Member Author

Dorukyum commented Dec 5, 2021

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

Lulalaby
Lulalaby previously approved these changes Dec 5, 2021
View reviewed changes
Copy link
Member

@Lulalaby Lulalaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CDE90 CDE90 mentioned this pull request Dec 6, 2021
Closed
3 tasks
@krittick krittick mentioned this pull request Dec 13, 2021
Closed
@krittick
Copy link
Contributor

I've tested this pretty extensively and it works great. I can't think of any improvements offhand and this should be a great baseline to have until Discord redesigns command groups. :shipit:

@Lulalaby Lulalaby merged commit 6646129 into master Dec 15, 2021
v2.0 automation moved this from In progress to Done Dec 15, 2021
@Lulalaby Lulalaby deleted the groups branch December 15, 2021 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krittick krittick krittick approved these changes

@Lulalaby Lulalaby Lulalaby approved these changes

@CodeWithSwastik CodeWithSwastik CodeWithSwastik approved these changes

@VincentRPS VincentRPS VincentRPS approved these changes

@BobDotCom BobDotCom Awaiting requested review from BobDotCom

Assignees

@Dorukyum Dorukyum

Labels
feature Implements a feature priority: high High Priority status: awaiting review Awaiting review from a maintainer
Projects
No open projects
v2.0
  
Done
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.

Group Commands in cog
7 participants
@Dorukyum @krittick @Lulalaby @CodeWithSwastik @BobDotCom @VincentRPS @HexF