Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds with_count to fetch_guild #465

Merged
merged 12 commits into from
Nov 16, 2021
Merged

adds with_count to fetch_guild #465

merged 12 commits into from
Nov 16, 2021

Conversation

JDJGInc
Copy link
Contributor

@JDJGInc JDJGInc commented Nov 16, 2021

Summary

Closes #159

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@Lulalaby Lulalaby added this to In progress in v2.0 via automation Nov 16, 2021
@Lulalaby Lulalaby added feature Implements a feature priority: low Low Priority status: awaiting review Awaiting review from a maintainer labels Nov 16, 2021
@JDJGInc
Copy link
Contributor Author

JDJGInc commented Nov 16, 2021

I have tested this, do you want me to swap it to uh

@JDJGInc
Copy link
Contributor Author

JDJGInc commented Nov 16, 2021

so wait_counts is OFf by Default or are you fine with this?

@JDJGInc
Copy link
Contributor Author

JDJGInc commented Nov 16, 2021

any like typing checks at all?

@JDJGInc
Copy link
Contributor Author

JDJGInc commented Nov 16, 2021

import discord
client = discord.Client(intents = discord.Intents.all())

@client.event
async def on_ready():
print("client is ready")

guild = await client.fetch_guild(guild_id)
print(guild.approximate_member_count, guild.approximate_presence_count)

guild = await client.fetch_guild(guild_id, with_counts = False)
print(guild.approximate_member_count, guild.approximate_presence_count)

TOKEN = ""
client.run(TOKEN)

@JDJGInc
Copy link
Contributor Author

JDJGInc commented Nov 16, 2021

Returns:
client is ready
522 297

@JDJGInc
Copy link
Contributor Author

JDJGInc commented Nov 16, 2021

Yes I know the test code is weird, but it works

@Lulalaby
Copy link
Member

Please do not spam comments.
Try to put everything in one.
Too many comments spams our discord GitHub feed Channel.

Furthermore I just assigned the needed things. You have to wait for reviewers.

For now this is fine, we come back with feedback later.

Copy link
Member

@Dorukyum Dorukyum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps you should add versionadded to the docstring

@JDJGInc
Copy link
Contributor Author

JDJGInc commented Nov 16, 2021

Perhaps you should add versionadded to the docstring

is this version 2.0.0?

@Dorukyum
Copy link
Member

Perhaps you should add versionadded to the docstring

is this version 2.0.0?

I guess so.

auto-merge was automatically disabled November 16, 2021 07:57

Head branch was pushed to by a user without write access

@JDJGInc
Copy link
Contributor Author

JDJGInc commented Nov 16, 2021

Perhaps you should add versionadded to the docstring

is this version 2.0.0?

I guess so.

this change should work, I am just waiting on checks to finish.

Copy link
Member

@Lulalaby Lulalaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent.
Please fix newlines and spaces

discord/guild.py Outdated Show resolved Hide resolved
JDJGInc and others added 2 commits November 16, 2021 03:03
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
discord/guild.py Outdated Show resolved Hide resolved
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
@Dorukyum
Copy link
Member

One last thing: there should be a newline before versionaddeds

@JDJGInc
Copy link
Contributor Author

JDJGInc commented Nov 16, 2021

Inconsistent. Please fix newlines and spaces

I have fixed everything I have seen, but I don't see the other fixes you want me to make.

discord/guild.py Show resolved Hide resolved
discord/guild.py Show resolved Hide resolved
discord/client.py Outdated Show resolved Hide resolved
discord/client.py Show resolved Hide resolved
Copy link
Contributor Author

@JDJGInc JDJGInc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what else do I need to fix here?

discord/guild.py Outdated Show resolved Hide resolved
discord/guild.py Outdated Show resolved Hide resolved
JDJGInc and others added 4 commits November 16, 2021 03:08
Co-authored-by: Lala Sabathil <aiko@aitsys.dev>
Co-authored-by: Lala Sabathil <aiko@aitsys.dev>
Co-authored-by: Lala Sabathil <aiko@aitsys.dev>
Co-authored-by: Lala Sabathil <aiko@aitsys.dev>
@JDJGInc
Copy link
Contributor Author

JDJGInc commented Nov 16, 2021

I have merged all the changes :D

@JDJGInc
Copy link
Contributor Author

JDJGInc commented Nov 16, 2021

how is change still requested, when I committed all the changes you wanted? nvm

@JDJGInc
Copy link
Contributor Author

JDJGInc commented Nov 16, 2021

Scrutinize just canceled itself?

@BobDotCom
Copy link
Member

Scrutinize just canceled itself?

It does when you push commits too close to each other. I've re-queued it.

@JDJGInc
Copy link
Contributor Author

JDJGInc commented Nov 16, 2021

Scrutinize just canceled itself?

It does when you push commits too close to each other. I've re-queued it.

Passed all checks :D

@Lulalaby Lulalaby merged commit 203eb31 into Pycord-Development:master Nov 16, 2021
v2.0 automation moved this from In progress to Done Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Implements a feature priority: low Low Priority status: awaiting review Awaiting review from a maintainer
Projects
No open projects
v2.0
  
Done
Development

Successfully merging this pull request may close these issues.

Fetch_guild getting with_counts
4 participants