-
-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds with_count to fetch_guild #465
Conversation
Someone complained it now being '' so I made it as such, I can revert it back if an issue
I have tested this, do you want me to swap it to uh |
so wait_counts is OFf by Default or are you fine with this? |
any like typing checks at all? |
import discord @client.event
TOKEN = "" |
Returns: |
Yes I know the test code is weird, but it works |
Please do not spam comments. Furthermore I just assigned the needed things. You have to wait for reviewers. For now this is fine, we come back with feedback later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps you should add versionadded
to the docstring
is this version 2.0.0? |
I guess so. |
Head branch was pushed to by a user without write access
this change should work, I am just waiting on checks to finish. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent.
Please fix newlines and spaces
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
One last thing: there should be a newline before |
I have fixed everything I have seen, but I don't see the other fixes you want me to make. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what else do I need to fix here?
Co-authored-by: Lala Sabathil <aiko@aitsys.dev>
Co-authored-by: Lala Sabathil <aiko@aitsys.dev>
Co-authored-by: Lala Sabathil <aiko@aitsys.dev>
Co-authored-by: Lala Sabathil <aiko@aitsys.dev>
I have merged all the changes :D |
how is change still requested, when I committed all the changes you wanted? nvm |
Scrutinize just canceled itself? |
It does when you push commits too close to each other. I've re-queued it. |
Passed all checks :D |
Summary
Closes #159
Checklist
type: ignore
comments were used, a comment is also left explaining why