Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore non dispatchable items when refreshing a view #50

Merged
merged 1 commit into from
Sep 1, 2021
Merged

Ignore non dispatchable items when refreshing a view #50

merged 1 commit into from
Sep 1, 2021

Conversation

Luc1412
Copy link
Contributor

@Luc1412 Luc1412 commented Aug 31, 2021

Summary

The pull request fixes #41 by ignoring non-dispatchable items when refreshing a view.

Context

When view.refresh() is called it can't find the component in https://github.com/Dorukyum/pycord/blob/master/discord/ui/view.py#L400
This causes the re-creation of that item with no row assigned. This causes the item to get moved in row 0.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@BobDotCom BobDotCom requested review from BobDotCom, Middledot, Dorukyum and CodeWithSwastik and removed request for BobDotCom August 31, 2021 22:42
@Dorukyum Dorukyum merged commit 4ce6ad7 into Pycord-Development:master Sep 1, 2021
@Dorukyum Dorukyum added this to Done in v2.0 Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
v2.0
  
Done
Development

Successfully merging this pull request may close these issues.

Components get moved randomly in a full Action Row on message/view update
3 participants