-
-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add autocomplete example #503
Conversation
Could probably use some work on the comments/docstrings for the example, though I tried to make it clear which concepts are being demonstrated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that! Thanks.
Not gonna approve it tho because I'm unsure about the variable naming.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe assign BASIC_ALLOWED and other config lists to bot.basic_allowed, etc.
Co-authored-by: BobDotCom <71356958+BobDotCom@users.noreply.github.com>
Head branch was pushed to by a user without write access
Co-authored-by: BobDotCom <71356958+BobDotCom@users.noreply.github.com>
I actually do this in my own bot and agree it's a best practice, but I figured that keeping things simple for this example would be best to keep the focus on the autocomplete functionality itself. It's easy enough (or should be) for bot developers to know to store those as class variables, etc. where appropriate. |
Agreeing with that |
Summary
Adds an autocomplete example that demonstrates both basic usage, and usage of the
AutocompleteContext.options
parameter.Closes #487
Checklist
type: ignore
comments were used, a comment is also left explaining why