-
-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new Thread.archive
#518
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because Thread.edit's bools defaults to MISSING.
VincentRPS
requested changes
Nov 30, 2021
Dorukyum
requested changes
Nov 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some wording inconsistencies. See the docstring for Thread.edit
.
Co-authored-by: RPS <vincentbusiness55@gmail.com>
auto-merge was automatically disabled
November 30, 2021 09:35
Head branch was pushed to by a user without write access
Co-authored-by: RPS <vincentbusiness55@gmail.com>
izxxr
suggested changes
Dec 2, 2021
Co-authored-by: Izhar Ahmad <54180221+nerdguyahmad@users.noreply.github.com>
Co-authored-by: Izhar Ahmad <54180221+nerdguyahmad@users.noreply.github.com>
Co-authored-by: Izhar Ahmad <54180221+nerdguyahmad@users.noreply.github.com>
VincentRPS
previously approved these changes
Dec 12, 2021
Lulalaby
requested changes
Dec 19, 2021
Lulalaby
reviewed
Dec 20, 2021
Lulalaby
previously approved these changes
Dec 21, 2021
Dorukyum
requested changes
Dec 21, 2021
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
Lulalaby
previously approved these changes
Dec 21, 2021
Dorukyum
approved these changes
Dec 29, 2021
Lulalaby
approved these changes
Dec 29, 2021
VincentRPS
added a commit
to VincentRPS/pycord
that referenced
this pull request
Jan 22, 2022
Co-authored-by: RPS <vincentbusiness55@gmail.com> Co-authored-by: Izhar Ahmad <54180221+nerdguyahmad@users.noreply.github.com> Co-authored-by: Lala Sabathil <aiko@aitsys.dev> Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new Thread.archive method that archives a thread.
Checklist
type: ignore
comments were used, a comment is also left explaining why