Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Thread.archive #518

Merged
merged 14 commits into from
Dec 29, 2021
Merged

Add new Thread.archive #518

merged 14 commits into from
Dec 29, 2021

Conversation

Sengolda
Copy link
Contributor

Summary

Adds a new Thread.archive method that archives a thread.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@Lulalaby Lulalaby added feature Implements a feature priority: low Low Priority labels Nov 29, 2021
@Lulalaby Lulalaby added this to In progress in v2.1 via automation Nov 29, 2021
@Lulalaby Lulalaby added this to the v2.1 milestone Nov 29, 2021
v2.1 automation moved this from In progress to Review in progress Nov 30, 2021
discord/threads.py Outdated Show resolved Hide resolved
discord/threads.py Outdated Show resolved Hide resolved
Copy link
Member

@Dorukyum Dorukyum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some wording inconsistencies. See the docstring for Thread.edit.

Co-authored-by: RPS <vincentbusiness55@gmail.com>
auto-merge was automatically disabled November 30, 2021 09:35

Head branch was pushed to by a user without write access

Co-authored-by: RPS <vincentbusiness55@gmail.com>
discord/threads.py Outdated Show resolved Hide resolved
discord/threads.py Outdated Show resolved Hide resolved
discord/threads.py Outdated Show resolved Hide resolved
Sengolda and others added 3 commits December 2, 2021 22:08
Co-authored-by: Izhar Ahmad <54180221+nerdguyahmad@users.noreply.github.com>
Co-authored-by: Izhar Ahmad <54180221+nerdguyahmad@users.noreply.github.com>
Co-authored-by: Izhar Ahmad <54180221+nerdguyahmad@users.noreply.github.com>
VincentRPS
VincentRPS previously approved these changes Dec 12, 2021
discord/threads.py Outdated Show resolved Hide resolved
discord/threads.py Show resolved Hide resolved
discord/threads.py Outdated Show resolved Hide resolved
Lulalaby
Lulalaby previously approved these changes Dec 21, 2021
discord/threads.py Outdated Show resolved Hide resolved
discord/threads.py Outdated Show resolved Hide resolved
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
Lulalaby
Lulalaby previously approved these changes Dec 21, 2021
@Dorukyum Dorukyum enabled auto-merge (squash) December 29, 2021 07:53
@Dorukyum Dorukyum merged commit e18099f into Pycord-Development:master Dec 29, 2021
v2.1 automation moved this from Review in progress to Ready Dec 29, 2021
v2.1 automation moved this from Ready to Done Dec 29, 2021
VincentRPS added a commit to VincentRPS/pycord that referenced this pull request Jan 22, 2022
Co-authored-by: RPS <vincentbusiness55@gmail.com>
Co-authored-by: Izhar Ahmad <54180221+nerdguyahmad@users.noreply.github.com>
Co-authored-by: Lala Sabathil <aiko@aitsys.dev>
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
@VincentRPS VincentRPS modified the milestones: v2.1, v2.0 Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Implements a feature priority: low Low Priority
Projects
No open projects
v2.1
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants