Use WeakValueDictionary for webhook locks. #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🗿 no checklist or summary smh |
I was in process of writing it, accidentally clicked create pr first. 😁 |
izxxr
changed the title
izxxr
added
bug
Lulalaby
approved these changes
Dec 15, 2021
|
|
Dorukyum
approved these changes
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #420.
Webhook adapters used simple
dictto store locks for ratelimit handling. This caused memory spikes for bots using interactions since they are mostly webhooks based. The size of dict kept growing. This PR fixes this issue by usingWeakValueDictionaryfor storing locks.Checklist
type: ignorecomments were used, a comment is also left explaining why