Include bot in interaction context #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgayfer
commented
Sep 1, 2021
jgayfer
commented
Sep 1, 2021
BobDotCom
approved these changes
Sep 1, 2021
jgayfer
force-pushed
the
context-bot
branch
2 times, most recently
from
4140060
to
8335366
Compare
Currently incoming application commands have no direct reference to the bot instance. This change includes the bot instance in our interaction context, much like how we do it in the commands extension. Having a reference to the bot is pretty handy, and fits well with the existing design of the library. A reference to the bot will also allow us to more easily reference a potential before_invoke or after_invoke hook from within discord.app.commands. Finally, by exposing a public get_context method, we open up the ability to define a custom context, a feature currently supported by the commands extension.
|
@Middledot Thanks! Ready for another look. |
Middledot
approved these changes
Sep 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently incoming application commands have no direct reference to the
bot instance. This change includes the bot instance in our interaction
context, much like how we do it in the commands extension.
Having a reference to the bot is pretty handy, and fits well with the
existing design of the library.
A reference to the bot will also allow us to more easily reference a
potential before_invoke or after_invoke hook from within
discord.app.commands.
Finally, by exposing a public get_context method, we open up the ability
to define a custom context, a feature currently supported by the
commands extension.
Caveats
I have not tested this with user or message commands (not entirely sure how to setup). I can revisit this area once I get a better idea if this is a direction we'd like to pursue.
Checklist