Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout example #613

Merged
merged 4 commits into from
Jan 1, 2022
Merged

Add timeout example #613

merged 4 commits into from
Jan 1, 2022

Conversation

Dorukyum
Copy link
Member

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@hypergonial
Copy link
Contributor

Shouldn't it be datetime.datetime.now(datetime.timezone.utc) or discord.utils.utcnow()? Otherwise it may not be timezone aware.

Copy link
Member

@BobDotCom BobDotCom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an example of the new method I'm adding (momentarily in a pull request)

Copy link
Contributor

@hypergonial hypergonial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

datetime.datetime.utcnow() still produces a naive-datetime, for this to be timezone-aware, please see my suggestions.

@Dorukyum Dorukyum added this to In progress in v2.0 via automation Dec 28, 2021
@Dorukyum Dorukyum mentioned this pull request Dec 29, 2021
7 tasks
@Dorukyum Dorukyum added priority: medium Medium Priority status: awaiting review Awaiting review from a maintainer labels Dec 30, 2021
@Lulalaby Lulalaby merged commit 6f642c4 into Pycord-Development:master Jan 1, 2022
v2.0 automation moved this from In progress to Done Jan 1, 2022
@Dorukyum Dorukyum deleted the timeout-example branch January 8, 2022 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: medium Medium Priority status: awaiting review Awaiting review from a maintainer
Projects
No open projects
v2.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants