Add support for Input Text and Modal components #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lulalaby
added
priority: medium
Lulalaby
previously approved these changes
Dec 24, 2021
|
Placed this under 2.1 since it might not release before 2.0 comes out. |
BobDotCom
added
status: planned
Lulalaby
added
Merge with squash
priority: high
Lulalaby
previously approved these changes
Jan 7, 2022
Dorukyum
previously approved these changes
Feb 1, 2022
Lulalaby
previously approved these changes
Feb 1, 2022
|
|
Middledot
reviewed
Feb 4, 2022
# Conflicts: # discord/bot.py
Co-authored-by: Middledot <78228142+Middledot@users.noreply.github.com>
Co-authored-by: Middledot <78228142+Middledot@users.noreply.github.com>
Co-authored-by: Middledot <78228142+Middledot@users.noreply.github.com>
|
Since this feature is now released, let's prioritize reviewing this ASAP. |
Text Input components are only available in modal dialogs. |
Lulalaby
approved these changes
Feb 9, 2022
Middledot
approved these changes
Feb 9, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remake of #573 because I broke things in my fork.
Note: Pretty much done, works as expected. Might need some more work on docstrings.
Checklist:
This adds support for input text and modal components.
Closes #490
Checklist
type: ignorecomments were used, a comment is also left explaining whyCredit to @Chiggy-Playz for their guidance in pointing me toward re-using many of the methodologies from View/Button/Select to quickly get our implementation running.