Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] Move ParamSpec import into if TYPE_CHECKING #659

Merged
merged 1 commit into from
Dec 29, 2021
Merged

[bugfix] Move ParamSpec import into if TYPE_CHECKING #659

merged 1 commit into from
Dec 29, 2021

Conversation

Dorukyum
Copy link
Member

Summary

Fixes an issue in #652 leading to a fatal error when importing discord.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@Dorukyum Dorukyum added bug Something isn't working priority: high High Priority status: awaiting review Awaiting review from a maintainer labels Dec 29, 2021
@Dorukyum Dorukyum self-assigned this Dec 29, 2021
@Dorukyum Dorukyum mentioned this pull request Dec 29, 2021
Closed
3 tasks
@Lulalaby Lulalaby linked an issue Dec 29, 2021 that may be closed by this pull request
Add typing_extentions to internal requirements.txt #660
Closed
3 tasks
@Lulalaby Lulalaby merged commit 758ff5f into Pycord-Development:master Dec 29, 2021
@Dorukyum Dorukyum deleted the fix-paramspec branch January 8, 2022 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lulalaby Lulalaby Lulalaby approved these changes

@ChickenDevs ChickenDevs ChickenDevs approved these changes

@BobDotCom BobDotCom Awaiting requested review from BobDotCom

@CodeWithSwastik CodeWithSwastik Awaiting requested review from CodeWithSwastik

@Middledot Middledot Awaiting requested review from Middledot

Assignees

@Dorukyum Dorukyum

Labels
bug Something isn't working priority: high High Priority status: awaiting review Awaiting review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add typing_extentions to internal requirements.txt
3 participants
@Dorukyum @Lulalaby @ChickenDevs