Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix groups #691

Merged
merged 3 commits into from
Jan 4, 2022
Merged

Fix groups #691

merged 3 commits into from
Jan 4, 2022

Conversation

Dorukyum
Copy link
Member

@Dorukyum Dorukyum commented Jan 3, 2022

Summary

Fixes issues with groups.

  • Allows not passing the name argument of the bot.group decorator.
  • Fixes an error with groups not having cooldown/max concurrency attributes.
  • Makes Group not inherit from Option since the required attributes are being set now.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@Lulalaby Lulalaby enabled auto-merge (rebase) January 4, 2022 00:45
@Lulalaby Lulalaby added bug Something isn't working Merge with rebase priority: high High Priority labels Jan 4, 2022
@Lulalaby Lulalaby added this to In progress in v2.0 via automation Jan 4, 2022
@Lulalaby Lulalaby added this to the v2.0 milestone Jan 4, 2022
@Lulalaby Lulalaby merged commit 99e2312 into Pycord-Development:master Jan 4, 2022
v2.0 automation moved this from In progress to Done Jan 4, 2022
@Dorukyum Dorukyum deleted the fix-groups branch January 4, 2022 16:18
@Middledot Middledot mentioned this pull request Jun 11, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lulalaby Lulalaby Lulalaby approved these changes

@ChickenDevs ChickenDevs ChickenDevs approved these changes

Assignees
No one assigned
Labels
bug Something isn't working priority: high High Priority
Projects
No open projects
v2.0
  
Done
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Dorukyum @Lulalaby @ChickenDevs