Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Thread As A Slash Command Option #706

Merged
merged 6 commits into from
Jan 12, 2022
Merged

Add Thread As A Slash Command Option #706

merged 6 commits into from
Jan 12, 2022

Conversation

Makiyu-py
Copy link
Contributor

Summary

Closes #480.

You use the new ThreadOption like this:

Option(ThreadOption("'public', 'private' or 'news'"), ...)

BTW the default channel type for discord.Thread is the public thread type.

May need some feedback on everything ThreadOption.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

VincentRPS
VincentRPS previously approved these changes Jan 5, 2022
View reviewed changes
Lulalaby
Lulalaby previously approved these changes Jan 5, 2022
View reviewed changes
@Lulalaby Lulalaby enabled auto-merge (squash) January 5, 2022 08:27
@Lulalaby Lulalaby added this to the v2.0 milestone Jan 7, 2022
@Lulalaby Lulalaby added priority: medium Medium Priority feature Implements a feature Merge with squash labels Jan 7, 2022
auto-merge was automatically disabled January 10, 2022 02:51

Head branch was pushed to by a user without write access

@Makiyu-py Makiyu-py dismissed stale reviews from Lulalaby and VincentRPS via 95b9771 January 10, 2022 02:51
Dorukyum
Dorukyum reviewed Jan 12, 2022
View reviewed changes
discord/commands/commands.py Outdated Show resolved Hide resolved
discord/commands/commands.py Outdated Show resolved Hide resolved
discord/enums.py Outdated Show resolved Hide resolved
@Makiyu-py @Dorukyum
Add Clone's suggestions
c21c74b 
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
Dorukyum
Dorukyum previously approved these changes Jan 12, 2022
View reviewed changes
@Dorukyum Dorukyum enabled auto-merge (squash) January 12, 2022 07:50
@Dorukyum Dorukyum merged commit 45f4753 into Pycord-Development:master Jan 12, 2022
VincentRPS pushed a commit to VincentRPS/pycord that referenced this pull request Jan 22, 2022
@Makiyu-py @VincentRPS
Add Thread As A Slash Command Option (Pycord-Development#706)
b5965ca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lulalaby Lulalaby Lulalaby approved these changes

@Dorukyum Dorukyum Dorukyum approved these changes

@VincentRPS VincentRPS VincentRPS left review comments

Assignees
No one assigned
Labels
feature Implements a feature priority: medium Medium Priority
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.

SlashCommandOptionType not support Thread class
4 participants
@Makiyu-py @Lulalaby @Dorukyum @VincentRPS