Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ext.pages] Fix missing current_page assignment, add page indicator update in goto_page #742

Merged
merged 1 commit into from
Jan 10, 2022

Conversation

krittick
Copy link
Contributor

Summary

This adds the missing current_page assignment in goto_page(), and also adds functionality to update the page indicator (if displayed) when goto_page() is used.

Closes #741

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@Lulalaby Lulalaby enabled auto-merge (rebase) January 10, 2022 00:58
@Lulalaby Lulalaby merged commit ef9b598 into Pycord-Development:master Jan 10, 2022
@krittick krittick deleted the ext-pages-hotfixes branch January 11, 2022 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

discord.ext.pages.Paginator does not update current_page attribute when page is changed using Paginator.goto()
3 participants