Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ext.pages] Add ability to specify in which row the paginator buttons are displayed #802

Merged
merged 10 commits into from
Jan 18, 2022
Merged

Conversation

krittick
Copy link
Contributor

Summary

This adds the missing row parameter to PaginatorButton to allow users to have more control over which rows their paginator buttons display in.

This also adds a new parameter default_button_row which controls the same behavior for the default set of paginator buttons.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@krittick krittick added priority: low Low Priority Merge with squash ext.pages Relating to ext.pages labels Jan 16, 2022
@krittick krittick self-assigned this Jan 16, 2022
@VincentRPS VincentRPS added this to the v2.0 milestone Jan 16, 2022
discord/ext/pages/pagination.py Outdated Show resolved Hide resolved
discord/ext/pages/pagination.py Outdated Show resolved Hide resolved
VincentRPS
VincentRPS previously approved these changes Jan 16, 2022
@Dorukyum
Copy link
Member

Shouldn't the type just be int since it's defaulted to 0?

@krittick
Copy link
Contributor Author

Shouldn't the type just be int since it's defaulted to 0?

Good catch, updated.

Dorukyum
Dorukyum previously approved these changes Jan 16, 2022
@krittick krittick merged commit d74fc1c into Pycord-Development:master Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext.pages Relating to ext.pages priority: low Low Priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants