-
-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ext.pages] Add ability to specify in which row the paginator buttons are displayed #802
Merged
krittick
merged 10 commits into
Pycord-Development:master
from
krittick:ext-pages-rowfix
Jan 18, 2022
Merged
[ext.pages] Add ability to specify in which row the paginator buttons are displayed #802
krittick
merged 10 commits into
Pycord-Development:master
from
krittick:ext-pages-rowfix
Jan 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krittick
added
priority: low
Low Priority
Merge with squash
ext.pages
Relating to ext.pages
labels
Jan 16, 2022
VincentRPS
requested changes
Jan 16, 2022
VincentRPS
previously approved these changes
Jan 16, 2022
Shouldn't the type just be |
Good catch, updated. |
Dorukyum
reviewed
Jan 16, 2022
Dorukyum
previously approved these changes
Jan 16, 2022
Dorukyum
approved these changes
Jan 18, 2022
Lulalaby
approved these changes
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds the missing
row
parameter toPaginatorButton
to allow users to have more control over which rows their paginator buttons display in.This also adds a new parameter
default_button_row
which controls the same behavior for the default set of paginator buttons.Checklist
type: ignore
comments were used, a comment is also left explaining why