Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back missing PartialMessageable import #828

Merged
merged 1 commit into from
Jan 22, 2022
Merged

Add back missing PartialMessageable import #828

merged 1 commit into from
Jan 22, 2022

Conversation

krittick
Copy link
Contributor

Summary

This adds back the import for PartialMessageable which was inadvertently removed in #821.

Fixes #827

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@krittick krittick self-assigned this Jan 21, 2022
@krittick krittick added the bug Something isn't working label Jan 21, 2022
@krittick krittick added this to In progress in v2.0 via automation Jan 21, 2022
@krittick krittick added this to the v2.0 milestone Jan 21, 2022
@krittick krittick merged commit 5244381 into Pycord-Development:master Jan 22, 2022
v2.0 automation moved this from In progress to Done Jan 22, 2022
@1oonie
Copy link
Contributor

1oonie commented Jan 22, 2022

This is still imported under if TYPE_CHECKING by the way.

@krittick
Copy link
Contributor Author

That does not expose the object for use outside of type checking. This needed to be added back.

@Dorukyum
Copy link
Member

I think they mean there is a duplicate import and the one under type checking can be removed.

@krittick
Copy link
Contributor Author

Ah, good catch then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
v2.0
  
Done
Development

Successfully merging this pull request may close these issues.

NameError: name 'PartialMessageable' is not defined
6 participants