Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slash converters #960

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

Ratery
Copy link
Contributor

@Ratery Ratery commented Feb 8, 2022

Summary

Fixed slash commands converters for basic discord classes (all of usual converters which haven't special input type).
For example:

discord.Option(discord.Message)

is equivalent to:

discord.Option(discord.ext.commands.MessageConverter)

But without this PR the first code raises an error.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@Dorukyum Dorukyum enabled auto-merge (squash) February 8, 2022 14:27
@Lulalaby Lulalaby enabled auto-merge (rebase) February 8, 2022 16:52
@Lulalaby Lulalaby merged commit 913f3bd into Pycord-Development:master Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants