Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type property to InputText #969

Merged
merged 1 commit into from
Feb 9, 2022
Merged

Add type property to InputText #969

merged 1 commit into from
Feb 9, 2022

Conversation

plun1331
Copy link
Member

@plun1331 plun1331 commented Feb 9, 2022

Summary

InputText was probably supposed to implement the type property as it is a subclass of Item, however, it doesn't.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue, i guess.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

Copy link
Contributor

@ephemeral8997 ephemeral8997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should choose the InputText type from types/components.py since It has a type, the current type property will always raise NotImplementedError.

@ephemeral8997
Copy link
Contributor

I misread some of your code, my comment was wrong.

Copy link
Contributor

@ephemeral8997 ephemeral8997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it does not have errors

@krittick krittick merged commit f505218 into Pycord-Development:master Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants