Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal and InputText updates/fixes #988

Merged
merged 12 commits into from
Feb 11, 2022
Merged

Modal and InputText updates/fixes #988

merged 12 commits into from
Feb 11, 2022

Conversation

krittick
Copy link
Contributor

Summary

This PR does the following:

  1. Removes Item inheritance from InputText as it's not needed for the latter to work
  2. Removes weights from Modal as it's not needed to determine whether a component will fit or not (only one input text fits per row, and only 5 rows are allowed).
  3. Fixes args/kwargs usage (includes change from Update input_text.py #984)
  4. Updates examples to better reflect the above change

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@krittick krittick added priority: high High Priority status: awaiting review Awaiting review from a maintainer Merge with squash labels Feb 10, 2022
@krittick krittick added this to the v2.0 milestone Feb 10, 2022
@krittick krittick added this to In progress in v2.0 via automation Feb 10, 2022
@krittick krittick self-assigned this Feb 10, 2022
@krittick krittick enabled auto-merge (squash) February 10, 2022 22:04
@krittick krittick merged commit 5db5e16 into Pycord-Development:master Feb 11, 2022
v2.0 automation moved this from In progress to Done Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high High Priority status: awaiting review Awaiting review from a maintainer
Projects
No open projects
v2.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant