added fix for issue #59

PydPiper · Nov 2, 2021 · 4bd2d95 · 4bd2d95
1 parent fc1de19
commit 4bd2d95
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/doc/source/revlog.rst b/doc/source/revlog.rst
@@ -3,6 +3,7 @@ Revision Log
 
 pypi version 1.59 (in-work)
 ---------------------------
+- bug fix: error in printing formulas that were read in as None type, see issue `#59 <https://github.com/PydPiper/pylightxl/issues/59>`_
 
 pypi version 1.58
 -----------------

diff --git a/pylightxl/pylightxl.py b/pylightxl/pylightxl.py
@@ -448,9 +448,9 @@ def readxl_scrape(fn, fn_ws, sharedString, styles, comments):
         cell_type = tag_cell.get('t')
         cell_style = int(tag_cell.get('s')) if tag_cell.get('s') is not None else 0
         tag_val = tag_cell.find('./default:v', ns)
-        cell_val = tag_val.text if tag_val is not None else ''
+        cell_val = tag_val.text or '' if tag_val is not None else ''
         tag_formula = tag_cell.find('./default:f', ns)
-        cell_formula = tag_formula.text if tag_formula is not None else ''
+        cell_formula = tag_formula.text or '' if tag_formula is not None else ''
         comment = comments[cell_address] if cell_address in comments.keys() else ''
 
         if all([entry == '' or entry is None for entry in [cell_val, cell_formula, comment]]):

diff --git a/test/newopenpyxl.xlsx b/test/newopenpyxl.xlsx