Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2017.05.21 #101

merged 102 commits into from May 22, 2017

2017.05.21 #101

merged 102 commits into from May 22, 2017


Copy link

@Ebag333 Ebag333 commented May 21, 2017

New Features

  • Revert skill: Can now revert back one skill change on individual skills in the char sheet. This allows you to undo the last change on a per skill basis.
  • Requirements: Greatly simplified requirements, making it easier to install (for users on Linux/OS X, and developers) and making the build packages significantly smaller.
  • Game Database: Update to latest version.
  • Pricing Stat Pane: For the minimal view, only include "above the line" items. This means that the minimal view will only show price totals for the hull and modules, as many people believe ammo, drones, and implants to either be sunk costs (spent regardless), or items that aren't often replaced. The full view will remain as is, showing full pricing for all items, and the pane will continue to default to the full view.

Boring Technical Stuff

  • Handle ship names with unicode characters in them
  • Catch up bugfixes from Pyfa-org related to characters. Thanks @blitzmann
  • Correct AppVeyor build numbers to use month instead of minute.
  • Large amount of code cleanup done to improve code quality.
  • Enable Linux and OS X builds for better testing, and to prepare for releases for them. (Note: If you'd like to test/assist with Linux/OS X builds, please reach out to me.)
  • Setup automatic upload of Linux and OS X builds to AWS.
  • Fix EVEMon character import where security status was not passed.
  • Catch up bugfixes with migrations, fighter prices, and removing something when it doesn't exist. Thanks @blitzmann
  • Improve logging in problematic areas, and convert old print statements to logbook.
Ebag333 and others added 30 commits May 12, 2017
Enhancement: Revert last skill change
…atch all conversion errors, but it should catch most.
Bugfix: Stacktrace when ship name has unicode chars
…, if the stage is selected first and the FitItem (self) is deleted before the FitRemoved is done, we get an error about how self is not valid anymore

(cherry picked from commit c68739d)
…jected fit for the same target threw an error

(cherry picked from commit 5e20d69)
…cause is (probably something firing in the wrong order). 9be4ae may also alleviate the root cause.

(cherry picked from commit ffe840e)
…rg#1160). Additionally, work around the fact that every module that is removed also recalculates the fit, allowing for a faster response time when deleting multiple modules at a time. This is somewhat ugly as the removeModule function was originally based on the assumption of removing only one module. Should clean it up at some point.

(cherry picked from commit d4ce1ef)
(cherry picked from commit 3b23c9e)
…h duplicate skills (since Skill has a backref to charactrer, it's automatically added to the characters skill list. No more need for the append())

(cherry picked from commit 7a0ea75)
…y/catch and handle else to catch scenarios where we fail to match.
Copy link

@codecov codecov bot commented May 21, 2017

Codecov Report

Merging #101 into master will decrease coverage by 0.02%.
The diff coverage is 20.86%.

@@            Coverage Diff             @@
##           master     #101      +/-   ##
- Coverage   14.54%   14.52%   -0.03%     
  Files        2177     2175       -2     
  Lines       35562    35519      -43     
- Hits         5174     5158      -16     
+ Misses      30388    30361      -27

Ebag333 added 8 commits May 21, 2017
… Travis.yml to use single S3 bucket for easier management.
…ing, as it's mildly confusing sincce they get lumped into a single value. Many people consider below the line items to be "sunk cost" or reusable items, and thus not worth counting.
Cleanup: Readme and .yml build

Enhancement: Remove Below The Line Costs
@Ebag333 Ebag333 merged commit c468f61 into master May 22, 2017
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants