Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2017.05.21 #101

Merged
merged 102 commits into from May 22, 2017

Conversation

@Ebag333
Copy link

commented May 21, 2017

New Features

  • Revert skill: Can now revert back one skill change on individual skills in the char sheet. This allows you to undo the last change on a per skill basis.
  • Requirements: Greatly simplified requirements, making it easier to install (for users on Linux/OS X, and developers) and making the build packages significantly smaller.
  • Game Database: Update to latest version.
  • Pricing Stat Pane: For the minimal view, only include "above the line" items. This means that the minimal view will only show price totals for the hull and modules, as many people believe ammo, drones, and implants to either be sunk costs (spent regardless), or items that aren't often replaced. The full view will remain as is, showing full pricing for all items, and the pane will continue to default to the full view.

Boring Technical Stuff

  • Handle ship names with unicode characters in them
  • Catch up bugfixes from Pyfa-org related to characters. Thanks @blitzmann
  • Correct AppVeyor build numbers to use month instead of minute.
  • Large amount of code cleanup done to improve code quality.
  • Enable Linux and OS X builds for better testing, and to prepare for releases for them. (Note: If you'd like to test/assist with Linux/OS X builds, please reach out to me.)
  • Setup automatic upload of Linux and OS X builds to AWS.
  • Fix EVEMon character import where security status was not passed.
  • Catch up bugfixes with migrations, fighter prices, and removing something when it doesn't exist. Thanks @blitzmann
  • Improve logging in problematic areas, and convert old print statements to logbook.

Ebag333 and others added some commits May 12, 2017

Merge pull request #87 from Pyfa-fit/skill_revert
Enhancement: Revert last skill change
Set all strings to be unicode when referencing fit.name. This won't c…
…atch all conversion errors, but it should catch most.
Merge pull request #88 from Pyfa-fit/unicode_shipname
Bugfix: Stacktrace when ship name has unicode chars
Move the FitRemoved event before the stage selected events. Otherwise…
…, if the stage is selected first and the FitItem (self) is deleted before the FitRemoved is done, we get an error about how self is not valid anymore

(cherry picked from commit c68739d)
Fix situation in which deleting a fit that was both a command and pro…
…jected fit for the same target threw an error

(cherry picked from commit 5e20d69)
Fix for pyfa-org#1161. Can't reproduce, but I'm unsure what the root …
…cause is (probably something firing in the wrong order). 9be4ae may also alleviate the root cause.

(cherry picked from commit ffe840e)
Fix issue with Delete key event on t3d mode causing exception (pyfa-o…
…rg#1160). Additionally, work around the fact that every module that is removed also recalculates the fit, allowing for a faster response time when deleting multiple modules at a time. This is somewhat ugly as the removeModule function was originally based on the assumption of removing only one module. Should clean it up at some point.

(cherry picked from commit d4ce1ef)
flake8
(cherry picked from commit 3b23c9e)
Fix issue with character copy, as well as instantiating character wit…
…h duplicate skills (since Skill has a backref to charactrer, it's automatically added to the characters skill list. No more need for the append())

(cherry picked from commit 7a0ea75)
Fix exception with character implants, and don't show implant set men…
…u if there aren't any (pyfa-org#1172)

(cherry picked from commit 65f71b6)
Merge pull request #89 from Pyfa-fit/bugfix_pyfa_catchup2
Catchup: Mostly Character Fixes
Use unicode match as the source data is formatted as unicode. Also tr…
…y/catch and handle else to catch scenarios where we fail to match.

Ebag333 and others added some commits May 19, 2017

Fixes EVEMon import. Security status was added, but wasn't handled in…
… the EVEMon import. Also, default secstatus to 0 if it's somehow missing.
Update some migrations to consider new schema (pyfa-org#1185)
* Update some migrations to consider new schema

* tox

(cherry picked from commit 2e2303c)
Merge pull request #98 from Pyfa-fit/bugfix_EVEMon_import
Bugfix: EVEMon Import broken due to missing security status
@codecov

This comment has been minimized.

Copy link

commented May 21, 2017

Codecov Report

Merging #101 into master will decrease coverage by 0.02%.
The diff coverage is 20.86%.

@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
- Coverage   14.54%   14.52%   -0.03%     
==========================================
  Files        2177     2175       -2     
  Lines       35562    35519      -43     
==========================================
- Hits         5174     5158      -16     
+ Misses      30388    30361      -27

Ebag333 added some commits May 21, 2017

Readme improvements. Cleanup old test stuff from AppVeyor.yml. Switch…
… Travis.yml to use single S3 bucket for easier management.
Due to popular request, removing all "below the line" items from pric…
…ing, as it's mildly confusing sincce they get lumped into a single value. Many people consider below the line items to be "sunk cost" or reusable items, and thus not worth counting.
Merge pull request #102 from Pyfa-fit/fix_readme
Cleanup: Readme and .yml build
Merge pull request #103 from Pyfa-fit/enhancement_remove_below_the_li…
…ne_costs

Enhancement: Remove Below The Line Costs

@Ebag333 Ebag333 merged commit c468f61 into master May 22, 2017

6 checks passed

codacy/pr Good work! A positive pull request.
Details
codecov/patch 20.86% of diff hit (target 14.54%)
Details
codecov/project Absolute coverage decreased by -0.02% but relative coverage increased by +6.31% compared to 216d29c
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.