Set CPU Affinity: Electric Boogaloo V2 #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully closes #115.
We now use psutil. This method also now is more cross-platform thanks to it. There is an improvement when the requests are split across multiple cores.
The reason why it is labeled as a hack is that we are applying the said affinities afterthe workers have been initialized.
I have found that trying to set it to before (RayWorkers generated from the bundles in the code above don't get affinities applied) or clearing (Clearing affinities set them back to (0,1) in my testing) doesn't yield good results. By explicitly setting affinities, we can avoid those problems.
I've also added a hyper-threading check. Not too sure what other method I can use from psutil but eh, it works?