Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: complete pending execution panic bugfix #519

Merged
merged 12 commits into from
Nov 24, 2021
Merged

fix: complete pending execution panic bugfix #519

merged 12 commits into from
Nov 24, 2021

Conversation

aljo242
Copy link
Contributor

@aljo242 aljo242 commented Nov 24, 2021

Description

Closes: #513

Adds a test to re-create the failing issue in the new misc_execs_test.go file.

The cause of the panic was due to a copy-paste error in GenerateExecutionResult() in complete_pending_execution.go. Please see modified file.

General cleanup of tests included in this PR.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

aljo242 and others added 11 commits November 24, 2021 10:00
* enable multi-seed sim in workflow

* remove old version of spec

* start doc

* add link in README

* cleanup

* initial add of recipe explanations

* remove old version of spec

* start doc

* add link in README

* cleanup

* initial add of recipe explanations

* start new section

* adding grid and extra info to fields

* removing paragraph at the end for recipe execution - its not needed to explain recipes at the moment.

* updating changelog.md with new pr

* update cookbook and recipe types

Co-authored-by: aljo242 <alex@shmeeload.xyz>
Co-authored-by: aljo242 <alex.johnson@tendermint.com>
* remove conditionlist

* update CHANGELOG.md
@aljo242 aljo242 self-assigned this Nov 24, 2021
@aljo242 aljo242 added the bug Something isn't working label Nov 24, 2021
@aljo242 aljo242 merged commit e73a57d into main Nov 24, 2021
@aljo242 aljo242 deleted the panic-bugfix branch November 24, 2021 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

recipe.Entries.ItemOutputs - index out of range
2 participants