Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: IBC setup docs was added #554

Merged
merged 2 commits into from Apr 6, 2022
Merged

docs: IBC setup docs was added #554

merged 2 commits into from Apr 6, 2022

Conversation

HassanRNS
Copy link
Contributor

@HassanRNS HassanRNS commented Apr 6, 2022

Description

How to setup IBC on local machine and payment from juno to pylons docs was added

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Copy link
Contributor

@BlackPanthar BlackPanthar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few typo edits

Copy link

@mustafapylons mustafapylons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typos and errors to correct are present, once corrected, can be approved.

docs/IBC-TRANSFER-WALKTHROUGH.md Outdated Show resolved Hide resolved
docs/IBC-TRANSFER-WALKTHROUGH.md Outdated Show resolved Hide resolved
docs/IBC-TRANSFER-WALKTHROUGH.md Outdated Show resolved Hide resolved
- http://localhost:36659
```
ics20_port: if default = ‘transfer’ else you can find the port-id in `x/type/keys.go`.
rpc values can be find inside the `config.yaml` file in both chains.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"found" instead of "find"

docs/IBC-TRANSFER-WALKTHROUGH.md Outdated Show resolved Hide resolved
docs/IBC-TRANSFER-WALKTHROUGH.md Outdated Show resolved Hide resolved
docs/IBC-TRANSFER-WALKTHROUGH.md Outdated Show resolved Hide resolved
docs/IBC-TRANSFER-WALKTHROUGH.md Outdated Show resolved Hide resolved
@MikeSofaer MikeSofaer merged commit cd4bfa2 into main Apr 6, 2022
@MikeSofaer MikeSofaer deleted the docs/ibc-setup branch April 6, 2022 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants