Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unify required, null, and drop #217

Merged
merged 2 commits into from Apr 29, 2015
Merged

Conversation

tisdall
Copy link
Contributor

@tisdall tisdall commented Apr 29, 2015

When I was trying to introspect schemas I printed out "missing: <object object at 0x7fa8787da240>", "missing: <colander.null>" and "missing: <colander._drop object at 0x7fa8737e4978>". The first is supposed to be a colander.required but unfortunately it's just a generic object placeholder. This PR is to unify colander.required, colander.drop and colander.null.

When I was trying to introspect schemas I printed out "missing:
<object object at 0x7fa8787da240>", "missing: <colander.null>" and
"missing: <colander._drop object at 0x7fa8737e4978>".  The first is
supposed to be a colander.required but unfortunately it's just a
generic object placeholder.  This PR is to unify colander.required,
colander.drop and colander.null.
@leplatrem
Copy link

👍

@stevepiercy
Copy link
Member

@tisdall
Copy link
Contributor Author

tisdall commented Apr 29, 2015

Sorry, I'm used to having __repr__ excluded from coverage tests.

tseaver added a commit that referenced this pull request Apr 29, 2015
unify `required`, `null`, and `drop`
@tseaver tseaver merged commit 0db2fbb into Pylons:master Apr 29, 2015
@tseaver
Copy link
Member

tseaver commented Apr 29, 2015

Thank you!

@tisdall tisdall mentioned this pull request May 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants