Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix iso8601 upgrade #295

Closed
wants to merge 4 commits into from
Closed

Fix iso8601 upgrade #295

wants to merge 4 commits into from

Conversation

beezz
Copy link

@beezz beezz commented Jul 28, 2017 •
edited

Fix for #294

A copy of the code previously in iso8601 behind try-except for ImportError. For tests to pass, parse_date and iso8601.iso8601.UTC needs to be patched.

It's an ugly solution. Let me know how to improve or maybe preferred solution would be to version pin iso8601 lib to 0.1.11.

Michal Kuffa added 4 commits July 28, 2017 18:07
Fix iso8601 upgrade
a3302f4 
Copy of code, previously in iso8601 behind try-except for ImportError. For
tests to pass, parse_date and iso8601.iso8601.UTC needs to be patched.
Triger Travis
850b047
Add test for Utc.__repr__
7861c31
Change eq of FixedOffset to reflect new iso8601
51a2a02
@tseaver
Copy link
Member

tseaver commented Jul 28, 2017

Thanks for the patch. I'd like to hold off on merging it until the iso8601 maintainer has a chance to address the backward-incompatibility reported in their tracker.

@tseaver
Copy link
Member

tseaver commented Jul 31, 2017

Looking more closely, I'm not sure we shouldn't just remove the colendar.iso8601 module altogether: it is only shims, and deform now imports iso8601.iso8601 directly.

tseaver added a commit that referenced this pull request Jul 31, 2017
@tseaver
Drop shim-only 'colander.iso8601' module.
4d2954d 
Use 'iso8601.iso8601' instead.

Closes #294.

Obsoletes #295.
@tseaver tseaver mentioned this pull request Jul 31, 2017
Merged
@tseaver
Copy link
Member

tseaver commented Jul 31, 2017

@beezz Again, thanks for your work!

After investigating, I think we are better off just deleting the colander.iso8601 module completely, and changing the code to use iso8601.iso8601 directly: see #296.

@tseaver tseaver closed this Jul 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@beezz @tseaver