Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] bootstrap5 + icons #124

Merged
merged 22 commits into from
Nov 14, 2023
Merged

[WIP] bootstrap5 + icons #124

merged 22 commits into from
Nov 14, 2023

Conversation

delijati
Copy link
Contributor

@delijati delijati commented Nov 8, 2023

Changes to work with bootstrap5 and bootstrap icons

@delijati
Copy link
Contributor Author

delijati commented Nov 8, 2023

We should also remove support for python < 3.10!?

@delijati
Copy link
Contributor Author

delijati commented Nov 9, 2023

Here a preview (will turn it off at some point) http://168.119.117.235:8523/

Copy link
Member

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. After I release deform 3.0.0a0, we will need to come back to this and bump that requirement. Thank you!

setup.py Outdated Show resolved Hide resolved
@stevepiercy
Copy link
Member

This is awesome work. Thank you so much for your effort.

Pylons Project projects try to support currently supported versions of Python when the project is released. Right now Python 3.8-3.12 are supported.

Would you please do two housekeeping tasks before I merge?

Copy link
Member

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python version support

README.rst Show resolved Hide resolved
Copy link
Member

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a more thorough review on this pass. A couple of minor changes, and I think it's good to go. Thank you!

.github/workflows/ci-tests.yml Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
Copy link
Member

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I'll merge this and then run CI in deform.

@stevepiercy stevepiercy merged commit 35d58c9 into Pylons:main Nov 14, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants