Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement watching extra files from CLI #28

Merged
merged 2 commits into from
May 23, 2017

Conversation

j-carl
Copy link
Contributor

@j-carl j-carl commented May 22, 2017

Implement watching extra files from CLI #18

Copy link
Member

@mmerickel mmerickel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase on master and add your name to CONTRIBUTORS.txt.


return runpy.run_module(
args.module,
**{"alter_sys": True, "run_name": "__main__"})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please modify this to use regular function kwargs - alter_sys=True, run_name='__main__'.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made the changes

@j-carl j-carl force-pushed the feature_18_watch_extra_files branch from e01e44c to ed3a782 Compare May 22, 2017 21:01
@mmerickel mmerickel merged commit 9103f22 into Pylons:master May 23, 2017
@mmerickel
Copy link
Member

Thanks @j-carl !

mmerickel added a commit that referenced this pull request May 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants