Fix messaging around the InvalidURI exception #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default behavior of InvalidURI would display the config_uri, but if you specify a message, that config_uri is not displayed, making troubleshooting hard. This adds `config_uri` to the exception message so you can tell what is broken. In my case it was `pshell -p bpython my.ini` which needed to be `pshell my.ini -p bpython` The exception message before this change didn't tell you what you needed to know (that `-p` was the `config_uri`)
|
Thank you @mark0978 ! |
This was referenced Oct 11, 2017
This was referenced Oct 30, 2017
This was referenced Nov 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default behavior of InvalidURI would display the config_uri, but if you specify a message, that config_uri is not displayed, making troubleshooting hard. This adds
config_urito the exception message so you can tell what is broken. In my case it waspshell -p bpython my.iniwhich needed to bepshell my.ini -p bpythonThe exception message before this change didn't tell you what you needed to know (that
-pwas theconfig_uri)