compatibility with pyramid 2 #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We also need to drop Python 2 support in this PR. Pyramid 2 dropped Python 2 support. See the failing tests in Travis CI for details. |
|
ok, you can see my attempt to drop it as a part of this PR. But you have to decide whether you really want to drop it. |
|
Thanks, @MeggyCal. One administrative detail, would you please sign https://github.com/Pylons/pyramid_chameleon/blob/master/CONTRIBUTORS.txt? Ping maintainers @mmerickel @bertjwregeer |
|
i can confirm this patch fixed the pyramid_chameleon compatibility with pyramid 2.x in Debian |
stevepiercy
requested changes
May 7, 2022
|
Superseded by #36 (sorry for the incredibly late response) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pyramid.compat was dropped in pyramid 2. As per Pylons/pyramid@b1a257b this should be equivalent.