Skip to content

Commit

Permalink
Merge pull request #301 from jvanasco/fix-296
Browse files Browse the repository at this point in the history
fix for #296, casting `show_on_exc_only` to bool.
  • Loading branch information
mmerickel committed May 18, 2017
2 parents 7f98e9d + 099eaeb commit 6583423
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
1 change: 1 addition & 0 deletions pyramid_debugtoolbar/__init__.py
Expand Up @@ -39,6 +39,7 @@
('button_style', None, ''),
('max_request_history', as_int, 100),
('max_visible_requests', as_int, 10),
('show_on_exc_only', asbool, 'false'),
]

# We need to transform these from debugtoolbar. to pyramid. in our
Expand Down
2 changes: 2 additions & 0 deletions tests/test_init.py
Expand Up @@ -24,6 +24,7 @@ def test_it(self):
'debugtoolbar.reload_templates': 'false',
'debugtoolbar.reload_resources': 'false',
'debugtoolbar.reload_assets': 'false',
'debugtoolbar.show_on_exc_only': 'false',
'debugtoolbar.prevent_http_cache': 'false',
'debugtoolbar.button_style': '',
'debugtoolbar.max_request_history': 100,
Expand All @@ -47,6 +48,7 @@ def test_it(self):
'debugtoolbar.reload_templates': False,
'debugtoolbar.reload_resources': False,
'debugtoolbar.reload_assets': False,
'debugtoolbar.show_on_exc_only': False,
'debugtoolbar.prevent_http_cache': False,
'debugtoolbar.active_panels': ['dummy_panel'],
'debugtoolbar.includes': [],
Expand Down

0 comments on commit 6583423

Please sign in to comment.