Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

squashed exceptions would cause a bug when logging the output #320

Merged
merged 3 commits into from
Jul 1, 2017
Merged

squashed exceptions would cause a bug when logging the output #320

merged 3 commits into from
Jul 1, 2017

Conversation

mmerickel
Copy link
Member

@mmerickel mmerickel commented Jul 1, 2017 •
edited
Loading

On python < 3.5 logger.exception would force the exc_info parameter to 1 or True (depending on the version). In 3.5 it was switched to a default kwarg that could be overridden. This fix uses log.error instead which does not force the value of exc_info on any version of Python.

fixes #319

@mmerickel mmerickel mentioned this pull request Jul 1, 2017
Closed
@mmerickel mmerickel merged commit 2ece679 into Pylons:master Jul 1, 2017
@pyup-bot pyup-bot mentioned this pull request Jul 1, 2017
Closed
@pyup-bot pyup-bot mentioned this pull request Jul 15, 2017
Merged
This was referenced Sep 15, 2017
Merged
Merged
Merged
Merged
Merged
@kwan0xfff kwan0xfff mentioned this pull request Dec 31, 2017
Closed
@pyup-bot pyup-bot mentioned this pull request Jun 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Logging issue on "raise httpexceptions.HTTPFound(url)"
1 participant
@mmerickel