added support for a default_action to config.add_handler #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added support for a "default_action" kwarg to add_handlers
This allows the following two config lines to be collapsed into one:
was:
config.add_handler("test", "/test/", "app.handlers.test:Test", action="index")
config.add_handler("test", "/test/{action}", "app.handlers.test:Test")
now:
config.add_handler("test", "/test/{action}", "app.handlers.test:Test", default_action="index")
it does this by implicitly creating another route named "test-default_action" , removing the ":action" args from the pattern, and subbing in "default_action" for "action"
I wasn't sure how the inheritance worked, so I used "add_handler(self" instead of "self.add_handler(".