update scaffold to be consistent with Pyramid's default scaffolds #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -38,15 +38,15 @@ | |||
| <span class="smaller">Jinja2 scaffold</span> | |||
| </h1> | |||
| <p class="lead"> | |||
| {% trans %}Hello{% endtrans %} to <span class="font-normal">\{\{ project \}\}</span>, an application generated by<br>the <span class="font-normal">Pyramid Web Framework 1.5.4</span>.</p> | |||
| {% trans %}Hello{% endtrans %} to <span class="font-normal">\{\{ project \}\}</span>, an application generated by<br>the <span class="font-normal">Pyramid Web Framework {{pyramid_version}}</span>.</p> | |||
There was a problem hiding this comment.
where is {{pyramid_version}} coming from? Does it need to be escaped like \{\{ project \}\}? Happy to merge if you tested this looks OK
There was a problem hiding this comment.
Both {{pyramid_version}} and {{pyramid_docs_branch}} are variables in the scaffold framework since Pylons/pyramid@0eff663
Escaping is not needed because pcreate renders the values, not the jinja2 template.
I've tested locally, and it works.
|
🍺 awesome job! |
domenkozar
added a commit
that referenced
this pull request
Jan 18, 2016
update scaffold to be consistent with Pyramid's default scaffolds
|
Thank you! Now I can update the Pyramid docs. 😀 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ping @domenkozar or @mmerickel for review.
This update might necessitate another release.