Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QueuedMailDelivery nor DirectMailDelivery do not accept transaction_manager keyword #80

Closed
ergo opened this issue Dec 7, 2016 · 4 comments

Comments

@ergo
Copy link
Member

ergo commented Dec 7, 2016

As per title currently including (via config.include('pyramid_mailer') pyramid_mailer breaks my application with:

File "/home/ergo/Private/workspace/pyramid_mailer/pyramid_mailer/init.py", line 11, in mailer_factory_from_settings
return Mailer.from_settings(settings, prefix)
File "/home/ergo/Private/workspace/pyramid_mailer/pyramid_mailer/mailer.py", line 281, in from_settings
return cls(username=username, password=password, **kwargs)
File "/home/ergo/Private/workspace/pyramid_mailer/pyramid_mailer/mailer.py", line 226, in init
self.smtp_mailer, transaction_manager=transaction_manager)
TypeError: init() got an unexpected keyword argument 'transaction_manager'

I've made a PR that resolves this, the test suite passes and I was able to successfully send email via:
mailer.send(message) and mailer.send_immediatelly(message)

@papachoco
Copy link

Any ETA for a new release?

@mmerickel
Copy link
Member

See my comment on #81. I am sorry for the trouble but I think you need to just pin pyramid_mailer alongside repoze.sendmail until you can upgrade to 4.2+.

@papachoco
Copy link

Thanks.. we have not been able to upgrade to repoze.sendmail because repoze/repoze.sendmail#31 which is a very serious bug which has not been fixed / released in quite sometime.

@mmerickel
Copy link
Member

Looks like this is now fixed in repoze.sendmail 4.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants