-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Python 3.8 and 3.9 #22
Conversation
Looks like AppVeyor may not support Python 3.9. I noticed that the latest version (3.7) was missing from this file before I started. |
Also add these versions to the declared classifiers.
31fff62
to
849a410
Compare
This is great, thank you for getting into it. As far as issues with travis or appveyor it's probably fine to just disable anything that's an issue. The ultimate goal will be to move to github actions similar to some of the other projects (pyramid_tm, hupper, waitress, etc). Is there anything I can do to kick appveyor or does 3.9 need to just be removed from it? |
I'm not familiar with AppVeyor, but I've pushed a fix to comment out the latest one. They do appear to support Python 3.9 according to their docs: But the previous build was failing with:
https://ci.appveyor.com/project/Pylons/pyramid-retry/builds/38721755/job/b0tje2v4od4pvta0 So I'm not sure. Presumably this is still a net win for Windows users as it adds 3.7 and 3.8? |
If you have time, there's also a very similar PR in to update |
This upgrades the tests and various CI files to include Python 3.8 and 3.9.
This also:
I don't have a way of verifying the
appveyor.yml
or Travis changes locally, but the tests pass on those versions of Python I can install locally.