Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added python3 support, please review #3

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

added python3 support, please review #3

wants to merge 3 commits into from

Conversation

reuleaux
Copy link

No description provided.

xmlrpclib -> xmlrpc.client / xmlrpc.server
now take care of the remaining three test failures
motivation and simple example: there was still a problem with
the code so far - cf. the docs...

works fine:
  s.say_hello('Chris')
  'Hello, Chris'

still ok:
  s.say_hello('Français')
  'Hello, Français'

failed, when there was a second non-ascii char involved:
  s.say_hello('Hello, Société Foo')
  boom!

fixed now, should be covered by a unit test.
@tseaver
Copy link
Member

tseaver commented Jan 29, 2013

Thank you for the pull request.

I think the readability of the "straddling" code would be improved by adding a 'compat' module to the package, from which all the other modules would just import the symbols they need, rather than scattering conditional imports through the code.

@reuleaux
Copy link
Author

Thanks for having had a look, I am somehow unexpetedly very busy at the
moment, so I am not sure when I will have the time to further improve
the code, but when doing so, will not hesitate to ask further questions.

1 similar comment
@reuleaux
Copy link
Author

Thanks for having had a look, I am somehow unexpetedly very busy at the
moment, so I am not sure when I will have the time to further improve
the code, but when doing so, will not hesitate to ask further questions.

@reuleaux reuleaux closed this Jan 30, 2013
@tseaver tseaver reopened this Jan 10, 2014
@tseaver
Copy link
Member

tseaver commented Jan 10, 2014

Andreas notes that he has moved away from using this module, in favor of 'pyramid_rpc.xmlrpc'. I've reopened this PR to allow for re-consideration of his porting work (as he won't be updating it himself).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants