added python3 support, please review #3

Open
wants to merge 3 commits into from

2 participants

@reuleaux

No description provided.

reuleaux added some commits Jan 10, 2013
@reuleaux reuleaux towards python3, so far the obvious changes:
xmlrpclib -> xmlrpc.client / xmlrpc.server
7e3b8b0
@reuleaux reuleaux towards python3:
now take care of the remaining three test failures
859d6f7
@reuleaux reuleaux in PY3 rely on the content_length calculated by webob.Response.
motivation and simple example: there was still a problem with
the code so far - cf. the docs...

works fine:
  s.say_hello('Chris')
  'Hello, Chris'

still ok:
  s.say_hello('Français')
  'Hello, Français'

failed, when there was a second non-ascii char involved:
  s.say_hello('Hello, Société Foo')
  boom!

fixed now, should be covered by a unit test.
628a7c9
@tseaver
Pylons Project member

Thank you for the pull request.

I think the readability of the "straddling" code would be improved by adding a 'compat' module to the package, from which all the other modules would just import the symbols they need, rather than scattering conditional imports through the code.

@reuleaux

Thanks for having had a look, I am somehow unexpetedly very busy at the
moment, so I am not sure when I will have the time to further improve
the code, but when doing so, will not hesitate to ask further questions.

@reuleaux

Thanks for having had a look, I am somehow unexpetedly very busy at the
moment, so I am not sure when I will have the time to further improve
the code, but when doing so, will not hesitate to ask further questions.

@reuleaux reuleaux closed this Jan 30, 2013
@tseaver tseaver reopened this Jan 10, 2014
@tseaver
Pylons Project member

Andreas notes that he has moved away from using this module, in favor of 'pyramid_rpc.xmlrpc'. I've reopened this PR to allow for re-consideration of his porting work (as he won't be updating it himself).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment