Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: tox/travis #17

Closed
wants to merge 8 commits into from
Closed

Update: tox/travis #17

wants to merge 8 commits into from

Conversation

digitalresistor
Copy link
Member

This is not entirely perfect yet, specifically at the moment test coverage does not work correctly due to:

pyramid_zcml/pyramid_zcml_tests_viewdecoratorapp_views_templates_foo_mak   NoSource: No source for code: '/Users/xistence/Projects/pyramid_zcml/pyramid_zcml/pyramid_zcml_tests_viewdecoratorapp_views_templates_foo_mak'.

I had to add -i to combine xml for it to even get to the stage of reporting coverage.

Currently a test file is also not fully covered:

pyramid_zcml/tests/routesapp/models.py                                         3      3     0%   1-4

This test run will still fail due to #8, but tox can now be re-run multiple times without the issues reported in #14.

Instead of defining them in tox.ini
This also removes Python 3.2 support since the new pip breaks that
As well as remove Python 3.2 and add Python 3.5
@tseaver
Copy link
Member

tseaver commented Mar 7, 2016

@bertjwregeer in order to get stuff passing to merge #16, I dropped 3.2 support. I part-way added 3.5 support (tox but not Travis). Can you merge / fixup?

@digitalresistor
Copy link
Member Author

I am currently over a satellite internet connection, and can't feasibly test locally (pulling down a tox env is painful).

@digitalresistor
Copy link
Member Author

@tseaver Seems like not everything is actually covered, also unless there is a way to get mako supported by coverage, we'll need to add an -i to the XML command for it to ignore any missing commands.

@fschulze
Copy link
Contributor

You might want to take a look at this: https://github.com/fschulze/pyramid_zcml/tree/tox-travis, but it doesn't merge coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants