On Windows, turn port into an integer #141
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't use service names instead of port numbers on Windows, so attempt to turn the port into an integer. If unable to do so, raise an error.
digitalresistor
force-pushed
the
bugfix/port_integer_windows
branch
from
f6818a7
to
2653db9
Compare
However Python 3 apparently does, since we have a test for this, and upon changing things tests started failing on Python 3 on Windows.
digitalresistor
force-pushed
the
bugfix/port_integer_windows
branch
from
2653db9
to
956a1c4
Compare
|
Merged this PR into #140. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't use service names instead of port numbers on Windows, so
attempt to turn the port into an integer. If unable to do so, raise an
error.
Requires #140 as well...
Closes #139