Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: Replace use of pkg_resources with importlib.metadata #380

Closed
kloczek opened this issue May 31, 2022 · 4 comments · Fixed by #398
Closed

RFE: Replace use of pkg_resources with importlib.metadata #380

kloczek opened this issue May 31, 2022 · 4 comments · Fixed by #398

Comments

@kloczek
Copy link

kloczek commented May 31, 2022

See discussions:
astropy/astropy#11091
pypa/pip#7413

[tkloczko@devel-g2v waitress-2.1.2]$ grep -r pkg_resources
docs/conf.py:import pkg_resources
docs/conf.py:version = pkg_resources.get_distribution("waitress").version
@mmerickel
Copy link
Member

This is a build time dependency. Yes it should be replaced but it is not affecting anyone except the maintainers of the library.

@kloczek
Copy link
Author

kloczek commented May 31, 2022

And packages .. this particular use of that module is messing in sys.path which disturbs building documentation.

@digitalresistor
Copy link
Member

How does it disturb building documentation?

@mmerickel
Copy link
Member

If you look at the linked setuptools issue it’s just a vendetta against pkg_resouces manipulating the sys.path but I can’t see why it matters for anyone building docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants