Use duck-typing to set a quasi-integer response status. #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please fix the failing tests. |
| try: | ||
| value += ' ' + status_reasons[int(value)] | ||
| except KeyError: | ||
| value += ' ' + status_generic_reasons[int(value) // 100] |
There was a problem hiding this comment.
We are losing some validation here I think.
response.status = 'InvalidStatusCodeString' will pass here and be set when it should fail, right?
|
I pulled your changes, and rebased them on top of master. |
digitalresistor
added a commit
that referenced
this pull request
Apr 14, 2015
Rebased PR #191, but apparently missed part of the patch. This fixes that.
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change checks for integer values when setting
response.statusby callingint()on the supplied value, instead of explicitly checking for a subclass ofint.This is helpful to me, because I'm writing code that wraps HTTP statuses in a class that defines
__int__(). I'd like to be able to use WebOb together with this class without having to check whether the Response object accepted the status, or whether I need to callint()(orstr()for that matter) and try again.This change additionally removes the need for the "
if ' ' not in value" check, which assumedvaluewas interpretable byint()anyway and then performed the same string substitution as the setter forresponse.status_code.