Skip to content

Handle 308 HTTP code for redirect#207

Merged
digitalresistor merged 1 commit into
Pylons:masterfrom
sileht:sileht/redirect-308
Sep 6, 2015
Merged

Handle 308 HTTP code for redirect#207
digitalresistor merged 1 commit into
Pylons:masterfrom
sileht:sileht/redirect-308

Conversation

@sileht
Copy link
Copy Markdown

@sileht sileht commented Jul 17, 2015

Hi,

This change handles 308 http code for permanent redirect

Cheers,

@mmerickel
Copy link
Copy Markdown
Member

+1 LGTM

@digitalresistor
Copy link
Copy Markdown
Member

This status code comes from https://datatracker.ietf.org/doc/rfc7538/?include_text=1

Unfortunately Google and others have also been using it for "Resume Incomplete", but I'll take RFC over some proposal that is non-RFC.

@mmerickel
Copy link
Copy Markdown
Member

This ticket[1] was compelling on the fact that google is supportive of the 308 rfc and it doesn't break any of their services.

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=714302

@digitalresistor
Copy link
Copy Markdown
Member

Perfect. So if the above issues get fixed, I'll pull this in :-)

@sileht
Copy link
Copy Markdown
Author

sileht commented Aug 20, 2015

I guess we can merge, so :)

@digitalresistor
Copy link
Copy Markdown
Member

@sileht There are a couple of typo's to still clear up.

@sileht sileht force-pushed the sileht/redirect-308 branch from 6ef4f49 to e3f182d Compare August 31, 2015 13:25
@sileht
Copy link
Copy Markdown
Author

sileht commented Aug 31, 2015

I have fixed the typos

@digitalresistor
Copy link
Copy Markdown
Member

You've removed a whole bunch of PY3 statements, and added a typo in one document that causes things to fail on PY3...

Please run tox locally, it will help you catch these errors. You can see the errors here: https://travis-ci.org/Pylons/webob/builds/78042379

@sileht sileht force-pushed the sileht/redirect-308 branch from e3f182d to c5af3cb Compare September 1, 2015 05:23
@sileht
Copy link
Copy Markdown
Author

sileht commented Sep 1, 2015

Sorry I push the wrong branch, this PL is just about 308.

This change handles 308 http code for permanent redirect
@sileht sileht force-pushed the sileht/redirect-308 branch from c5af3cb to 47881a4 Compare September 1, 2015 05:27
@digitalresistor digitalresistor added this to the Version 1.5 milestone Sep 3, 2015
digitalresistor added a commit that referenced this pull request Sep 6, 2015
@digitalresistor digitalresistor merged commit 47881a4 into Pylons:master Sep 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants