Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle 308 HTTP code for redirect #207

Merged
merged 1 commit into from Sep 6, 2015

Conversation

sileht
Copy link

@sileht sileht commented Jul 17, 2015

Hi,

This change handles 308 http code for permanent redirect

Cheers,

@mmerickel
Copy link
Member

+1 LGTM

@digitalresistor
Copy link
Member

This status code comes from https://datatracker.ietf.org/doc/rfc7538/?include_text=1

Unfortunately Google and others have also been using it for "Resume Incomplete", but I'll take RFC over some proposal that is non-RFC.

@mmerickel
Copy link
Member

This ticket[1] was compelling on the fact that google is supportive of the 308 rfc and it doesn't break any of their services.

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=714302

@digitalresistor
Copy link
Member

Perfect. So if the above issues get fixed, I'll pull this in :-)

@sileht
Copy link
Author

sileht commented Aug 20, 2015

I guess we can merge, so :)

@digitalresistor
Copy link
Member

@sileht There are a couple of typo's to still clear up.

@sileht
Copy link
Author

sileht commented Aug 31, 2015

I have fixed the typos

@digitalresistor
Copy link
Member

You've removed a whole bunch of PY3 statements, and added a typo in one document that causes things to fail on PY3...

Please run tox locally, it will help you catch these errors. You can see the errors here: https://travis-ci.org/Pylons/webob/builds/78042379

@sileht
Copy link
Author

sileht commented Sep 1, 2015

Sorry I push the wrong branch, this PL is just about 308.

This change handles 308 http code for permanent redirect
@digitalresistor digitalresistor added this to the Version 1.5 milestone Sep 3, 2015
digitalresistor added a commit that referenced this pull request Sep 6, 2015
@digitalresistor digitalresistor merged commit 47881a4 into Pylons:master Sep 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants