Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle 308 HTTP code for redirect #207

Merged
merged 1 commit into from Sep 6, 2015

Conversation

@sileht
Copy link
Contributor

@sileht sileht commented Jul 17, 2015

Hi,

This change handles 308 http code for permanent redirect

Cheers,

@mmerickel
Copy link
Member

@mmerickel mmerickel commented Jul 17, 2015

+1 LGTM

@bertjwregeer
Copy link
Member

@bertjwregeer bertjwregeer commented Jul 18, 2015

This status code comes from https://datatracker.ietf.org/doc/rfc7538/?include_text=1

Unfortunately Google and others have also been using it for "Resume Incomplete", but I'll take RFC over some proposal that is non-RFC.

@mmerickel
Copy link
Member

@mmerickel mmerickel commented Jul 18, 2015

This ticket[1] was compelling on the fact that google is supportive of the 308 rfc and it doesn't break any of their services.

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=714302

@bertjwregeer
Copy link
Member

@bertjwregeer bertjwregeer commented Jul 18, 2015

Perfect. So if the above issues get fixed, I'll pull this in :-)

@sileht
Copy link
Contributor Author

@sileht sileht commented Aug 20, 2015

I guess we can merge, so :)

@bertjwregeer
Copy link
Member

@bertjwregeer bertjwregeer commented Aug 20, 2015

@sileht There are a couple of typo's to still clear up.

@sileht sileht force-pushed the sileht:sileht/redirect-308 branch from 6ef4f49 to e3f182d Aug 31, 2015
@sileht
Copy link
Contributor Author

@sileht sileht commented Aug 31, 2015

I have fixed the typos

@bertjwregeer
Copy link
Member

@bertjwregeer bertjwregeer commented Aug 31, 2015

You've removed a whole bunch of PY3 statements, and added a typo in one document that causes things to fail on PY3...

Please run tox locally, it will help you catch these errors. You can see the errors here: https://travis-ci.org/Pylons/webob/builds/78042379

@sileht sileht force-pushed the sileht:sileht/redirect-308 branch from e3f182d to c5af3cb Sep 1, 2015
@sileht
Copy link
Contributor Author

@sileht sileht commented Sep 1, 2015

Sorry I push the wrong branch, this PL is just about 308.

Mehdi Abaakouk
This change handles 308 http code for permanent redirect
@sileht sileht force-pushed the sileht:sileht/redirect-308 branch from c5af3cb to 47881a4 Sep 1, 2015
@bertjwregeer bertjwregeer added this to the Version 1.5 milestone Sep 3, 2015
bertjwregeer added a commit that referenced this pull request Sep 6, 2015
@bertjwregeer bertjwregeer merged commit 47881a4 into Pylons:master Sep 6, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants