Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle the short form of <select multiple> #62

Merged
merged 1 commit into from Apr 1, 2013

Conversation

mgedmin
Copy link
Contributor

@mgedmin mgedmin commented Mar 28, 2013

See http://www.w3.org/TR/REC-html40/interact/forms.html#adef-multiple
if you need convincing that this is valid HTML (first example, a couple
of pages down).

@domenkozar
Copy link
Member

Could you also add a changelog entry?

@mgedmin
Copy link
Contributor Author

mgedmin commented Mar 29, 2013

How about

* Handle the short form of <select multiple> [Marius Gedminas]

I'd update CHANGELOG.rst in my branch, but it was created before the 2.0.4 release, so any modification would just cause conflicts. Unless I merge master first, which will produce a tangled history. Or rebase, which is a no-no for published branches.

What's the proper Github etiquette for this?

@domenkozar
Copy link
Member

just rebase on master and git push -f

See http://www.w3.org/TR/REC-html40/interact/forms.html#adef-multiple
if you need convincing that this is valid HTML (first example, a couple
of pages down).
@mgedmin
Copy link
Contributor Author

mgedmin commented Apr 1, 2013

Rebased, pushed.

domenkozar added a commit that referenced this pull request Apr 1, 2013
Handle the short form of <select multiple>
@domenkozar domenkozar merged commit c349f66 into Pylons:master Apr 1, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants